On Tue, 2 Jun 2026 at 17:12, Ajinkya Udgirkar <[email protected]> wrote: > > Replace libc calloc() with GLib g_new0() for consistency with the > rest of the QEMU codebase. g_new0() aborts on allocation failure > rather than returning NULL, which matches QEMU's allocation policy. > > Signed-off-by: Ajinkya Udgirkar <[email protected]> > --- > hw/xtensa/mx_pic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/xtensa/mx_pic.c b/hw/xtensa/mx_pic.c > index 098c1aa..8ded3bc 100644 > --- a/hw/xtensa/mx_pic.c > +++ b/hw/xtensa/mx_pic.c > @@ -343,7 +343,7 @@ static void xtensa_mx_pic_set_irq(void *opaque, int irq, > int active) > > XtensaMxPic *xtensa_mx_pic_init(unsigned n_irq) > { > - XtensaMxPic *mx = calloc(1, sizeof(XtensaMxPic)); > + XtensaMxPic *mx = g_new0(XtensaMxPic, 1); > > mx->n_irq = n_irq + 1; > mx->irq_inputs = qemu_allocate_irqs(xtensa_mx_pic_set_irq, mx, > --
Reviewed-by: Peter Maydell <[email protected]> Ideally this device needs to be converted to qdev; then it would not be allocating memory here at all. thanks -- PMM
