On Mon, 8 Jun 2026 at 16:25, Emmanuel Blot <[email protected]> wrote:
>
> On macOS, plain QEMU binaries are named qemu-system-<arch>-unsigned.
>
> In libqtest, qtest_get_arch() extracts the architecture by splitting
> after "-system-", which yields "arm-unsigned" instead of "arm".  This
> prevents the QOS graph from matching any machine node, causing all
> QOS-based tests to be silently skipped.
>
> In the functional test framework, the same suffix causes the arch to
> be parsed as "unsigned", leading to wrong output directories and
> teardown failures.
>
> Strip the "-unsigned" suffix on both code paths.
>
> Signed-off-by: Emmanuel Blot <[email protected]>
> ---
> Address issues with liqtest and functional test framework when run from
> a macOS host.
>
> Unsigned binaries on macOS may be appended an `-unsigned` suffix, which
> confuse these components that rely on the binary name to recover the
> guest architecture.

I still think this not the right thing to do. The "make" process
on macos should produce and sign the binary in-place in the
build tree, so that users and test cases don't have to care
about this macos specific weirdness. (If the signing is
location-specific and we need to sign again for "make install"
that's fine. But we should produce a working binary with the
usual name in the build tree, not a non-working one or one with a
nonstandard name.)

See also this earlier thread:
https://lore.kernel.org/qemu-devel/cafeaca_txohplk+j546yjcmoev0-ptavkcek5gfel13ddqq...@mail.gmail.com/

thanks
-- PMM

Reply via email to