Hi,
On Wed, Jun 10, 2026 at 04:27:18PM +0200, Gerd Hoffmann wrote:
Hi,
No, when IGVM is not enabled in the build it's not possible to trigger
any of these stubs. On top of that, I don't think it is possible to trigger
these stubs even when igvm is enabled. This is because the only architecture
that implements igvm support in qemu is x86.
We have these stubs mainly to avoid linker errors when compiling igvm
support on !x86 architectures. So we do compile igvm support for other
architectures (or, to be exact, we compile the core igvm code once and
link it into all qemu-system-$arch variants).
Nevertheless I think that the stubs should not be reachable. The igvm
code already has checks like this ...
} else if (target_arch() == SYS_EMU_TARGET_X86_64) {
result = qigvm_x86_set_vp_context(data, vp_context->vp_index, errp);
... so it should never try to call x86 support code on
qemu-system-$somethingelse.
On that base I think switching to asserts should be fine. If we
actually hit any assert the core code lacks a sanity check.
take care,
Gerd
Right, I got confused by madt function not checking the arch.
Ignore this patch, I'll send a new series that improves madt and switches
to asserts.
Sorry for the confusion.
Thanks,
Luigi
