On 6/8/26 7:49 AM, Thomas Huth wrote: > On 03/06/2026 20.50, Eric Farman wrote: >> On Tue, 2026-05-05 at 16:19 -0400, Zhuoying Cai wrote: >>> Add functional test for secure IPL. > ... >>> diff --git a/tests/functional/s390x/test_secure_ipl.py >>> b/tests/functional/s390x/test_secure_ipl.py >>> new file mode 100755 >>> index 0000000000..0980daace1 >>> --- /dev/null >>> +++ b/tests/functional/s390x/test_secure_ipl.py >>> @@ -0,0 +1,148 @@ >>> +#!/usr/bin/env python3 >>> +# >>> +# s390x Secure IPL functional test: validates secure-boot verification >>> results >>> +# >>> +# SPDX-License-Identifier: GPL-2.0-or-later >> >> A general comment, you'll need some form of docstring for the entire file, >> and any classes/methods >> defined later on. > > Yes, please make sure that the "pylint" does not complain about your file > (minimum is "pylint --rcfile tests/functional/pylintrc ...", better is > without the rc file). > > Thanks, > Thomas >
Thank you for the feedback! I’ll add docstrings to all classes and methods and make sure the file passes pylint checks in the next version.
