On 6/11/2026 7:49 AM, Paolo Bonzini wrote: > On Wed, Jun 10, 2026 at 7:01 PM Pierrick Bouvier > <[email protected]> wrote: >> Your idea is to have one project per target, and use meson cross compile >> support for this? > > Yes, that was the idea. > >> `make check-tcg-aarch64-softmu` is supported out of the box with this >> series, without having to write a single line of Makefile. You can still >> do what you like: see cover letter usage, to run a suite or a single test. >> I don't see rewriting the cc_feat part in meson directly as a problem to >> be honest. Not all architectures needs to check specific feat (only >> aarch64, arm, i386, ppc64 and s390x). >> >> Also, calling: >> supported = run_command[cc, check_cflags, flags].returncode() == 0 >> vs >> cc.get_supported_arguments(flags) >> is not really much more complex IMHO, and not a huge reinvention. >> >> Also, the custom target is hidden inside tcg/tests/meson.build and not >> exposed to arch files. Even if we had multiple projects, I would stick >> to not exposing test() and executable() in arch files. > > Fair enough. > >> I would expect this file to disappear completely, and to rely on make >> check-tcg-arch-* targets at top level instead. Would that work for you? > > Yeah, you're right that at this point TCG tests are the last > stragglers in that file. That tilts the balance for me, it does make > sense to do this with custom_target() until Meson grows support for > something like multi-machine projects. Just please add an alias_target > 'build-tcg-tests-...' for compatibility with tests/Makefile.include. >
Sure, that's a good idea. I was wondering as well if we should build those tests by default (as part of 'all' target). We should do this only if cross compiler is not using any container, to avoid triggering a confusing container build. Any opinion? > Paolo >
