On 6/10/2026 11:00 PM, Manos Pitsidianakis wrote: > On Wed, 03 Jun 2026 23:51, Pierrick Bouvier > <[email protected]> wrote: >> Signed-off-by: Pierrick Bouvier <[email protected]> >> --- >> include/plugins/qemu-plugin.h | 8 ++++++-- >> plugins/api.c | 5 +++-- >> plugins/core.c | 2 +- >> tests/tcg/plugins/syscall.c | 5 +++-- >> 4 files changed, 13 insertions(+), 7 deletions(-) >> >> diff --git a/include/plugins/qemu-plugin.h b/include/plugins/qemu- >> plugin.h >> index d82d996bce6..909f19b7128 100644 >> --- a/include/plugins/qemu-plugin.h >> +++ b/include/plugins/qemu-plugin.h >> @@ -840,12 +840,14 @@ void qemu_plugin_update_ns(const void *handle, >> int64_t time); >> * @a6: the 6th syscall argument >> * @a7: the 7th syscall argument >> * @a8: the 8th syscall argument >> + * @userdata: user data for callback >> */ >> typedef void >> (*qemu_plugin_vcpu_syscall_cb_t)(unsigned int vcpu_index, >> int64_t num, uint64_t a1, uint64_t a2, >> uint64_t a3, uint64_t a4, uint64_t a5, >> - uint64_t a6, uint64_t a7, uint64_t a8); >> + uint64_t a6, uint64_t a7, uint64_t a8, >> + void *userdata); >> >> /** >> * typedef qemu_plugin_vcpu_syscall_filter_cb_t - vCPU syscall filter >> callback >> @@ -891,13 +893,15 @@ typedef void >> * qemu_plugin_register_vcpu_syscall_cb() - register a syscall entry >> callback >> * @id: plugin id >> * @cb: callback of type qemu_plugin_vcpu_syscall_cb_t >> + * @userdata: user data for callback > > Suggestion: I noticed in some patches you say "for @cb" and sometimes > "for callback", if you re-spin this series you could make them > consistent if you wish. >
I added a commit on top changing all comments to "user data for callback", since cb may or may not be present, depending if it's callback registration, or type. > Reviewed-by: Manos Pitsidianakis <[email protected]> > ... Regards, Pierrick
