On Tue, 16 Jun 2026 05:08, Philippe Mathieu-Daudé <[email protected]>
wrote:
cpu_physical_memory_write() is legacy (see commit b7ecba0f6f6),
replace it by address_space_write(). Both if() ladders only
differ in the address space argument: rework to have a single
address_space_write() call. No logical change intended.
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
Reviewed-by: Manos Pitsidianakis <[email protected]>
accel/kvm/kvm-all.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 96f90ebb240..f4f0e64fbd0 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -3178,16 +3178,12 @@ void kvm_flush_coalesced_mmio_buffer(void)
struct kvm_coalesced_mmio_ring *ring = s->coalesced_mmio_ring;
while (ring->first != ring->last) {
struct kvm_coalesced_mmio *ent;
+ const AddressSpace *as;
ent = &ring->coalesced_mmio[ring->first];
-
- if (ent->pio == 1) {
- address_space_write(&address_space_io, ent->phys_addr,
- MEMTXATTRS_UNSPECIFIED, ent->data,
- ent->len);
- } else {
- cpu_physical_memory_write(ent->phys_addr, ent->data, ent->len);
- }
+ as = ent->pio == 1 ? &address_space_io : &address_space_memory;
+ address_space_write(as, ent->phys_addr, MEMTXATTRS_UNSPECIFIED,
+ ent->data, ent->len);
smp_wmb();
ring->first = (ring->first + 1) % KVM_COALESCED_MMIO_MAX;
}
--
2.53.0
