Hi Jared,
On 17/6/26 14:12, Jared Rossi wrote:
Hi Philippe,
This patch does not apply for me. Is there any prerequisite for this?
On my side it fails to match the existing includes in hw/s390x/ipl.c
because
system/physmem.h is not currently there, but is expected by this patch.
Also in target/s390x/diag.c the s390_ipl_write() function is not present.
Taking a quick look, it seems like you added that function in a different
series, specifically in:
[PATCH v2 4/6] target/s390x: Factor common s390_ipl_read/write() helpers
Sorry if I've missed something, but is this meant to be part of a series?
Well my bad, I'm never sure when to repost already reviewed series.
Considering there is now a v3 for this patch, I'll repost as v4
including the reviewed pre-requisites. Thanks for giving it a try!
v3:
https://lore.kernel.org/qemu-devel/[email protected]/
Thanks,
Jared Rossi
On 6/15/26 10:16 PM, Philippe Mathieu-Daudé wrote:
Rather than calling a TCG specific method in s390_ipl_reset_request(),
have handle_diag_308() return whether a vCPU reset is pending, and use
that in the TCG DIAG helper to return to the main loop.
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
target/s390x/s390x-internal.h | 3 ++-
hw/s390x/ipl.c | 5 -----
target/s390x/diag.c | 30 +++++++++++++++++++-----------
target/s390x/tcg/misc_helper.c | 5 ++++-
4 files changed, 25 insertions(+), 18 deletions(-)
