On 6/17/26 09:25, Philippe Mathieu-Daudé wrote:
On 17/6/26 17:34, Philippe Mathieu-Daudé wrote:
On 17/6/26 16:44, Richard Henderson wrote:
On 6/16/26 12:17, Philippe Mathieu-Daudé wrote:
Of the 5 calls in our codebase, 4 are unlikely(), so not worth
inlining in header. Since the CPUState is simply read-only
accessed, make the argument const.
Unlikely to trigger, but still called within inner loops.
Please keep this inline.
Why not inline all of them then? What is so special about
this particular one?
I'd really like to not pull the whole "hw/core/cpu.h" there:
include/accel/tcg/cpu-loop.h:87:38: error: incomplete definition of type 'const
CPUState' (aka 'const struct CPUState')
87 | return (int32_t)qatomic_read(&cpu->neg.icount_decr.u32) < 0;
| ~~~^
Then perhaps we should leave this one in cpu-common.h.
r~
