On Wed, 3 Jun 2026 02:15:01 -0400 "Michael S. Tsirkin" <[email protected]> wrote:
> On Tue, Mar 03, 2026 at 10:25:18AM +0100, Igor Mammedov wrote: > > Comment about keeping legacy freq, is wrong to begin with > > (should be 62.5MHz), but that value also doesn't make > > sense anymore as the watchdog is used only by un-versioned > > SBSA board and the later has hard-coded it to 1GHz. > > > > Other potential user (arm/virt) also has system clock at 1GHz. > > > > Drop misleading comment about legacy and set default to 1GHz > > to match both boards. > > > > Signed-off-by: Igor Mammedov <[email protected]> > > > if I take this in isolation then make check seems to fail > on qemu:qtest-arm/aspeed_smc-test. it works over here, it must have been a glitch, gwdt isn't used by this board, the sole user of it is hw/arm/sbsa-ref.c at this point > > follow up patches fix it, but I think it has to be reordered > to avoid breaking bisect. > > > > > --- > > hw/watchdog/sbsa_gwdt.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/hw/watchdog/sbsa_gwdt.c b/hw/watchdog/sbsa_gwdt.c > > index 7ade5c6f18..b739a3ce3c 100644 > > --- a/hw/watchdog/sbsa_gwdt.c > > +++ b/hw/watchdog/sbsa_gwdt.c > > @@ -264,11 +264,10 @@ static void wdt_sbsa_gwdt_realize(DeviceState *dev, > > Error **errp) > > static const Property wdt_sbsa_gwdt_props[] = { > > /* > > * Timer frequency in Hz. This must match the frequency used by > > - * the CPU's generic timer. Default 62.5Hz matches QEMU's legacy > > - * CPU timer frequency default. > > + * the CPU's generic timer. > > */ > > DEFINE_PROP_UINT64("clock-frequency", struct SBSA_GWDTState, freq, > > - 62500000), > > + 1000000000), > > }; > > > > static void wdt_sbsa_gwdt_class_init(ObjectClass *klass, const void *data) > > -- > > 2.47.3 >
