On Thu, Jun 18, 2026 at 4:12 PM Philippe Mathieu-Daudé < [email protected]> wrote:
> On 18/6/26 21:55, Richard Henderson wrote: > > Merge the PT_LOAD loop with the PT_INTERP loop, as the XXX > > comment suggests. Pass the probed range to probe_guest_base. > > > > Signed-off-by: Richard Henderson <[email protected]> > > --- > > bsd-user/elfload.c | 37 +++++++++++++++++++------------------ > > bsd-user/main.c | 39 ++++----------------------------------- > > 2 files changed, 23 insertions(+), 53 deletions(-) > > > > + /* Ensure that mmap_next_start is within range. */ > > + if (reserved_va && reserved_va <= mmap_next_start) { > > + mmap_next_start = ((reserved_va / 4 * 3) > > Is that ROUND_DOWN(reserved_va, 4)? > > > + & TARGET_PAGE_MASK & qemu_host_page_mask); > > } > > Rest LGTM AFAICT :) > > Reviewed-by: Philippe Mathieu-Daudé <[email protected]> > Same comment Reviewed-by: Warner Losh <[email protected]>
