Re: [PATCH v3 03/15] s390x/pci: Move iommu_mr from S390PCIIOMMU to S390PCIBusDevice

[Farhan Ali]

<..snip..>

On 6/4/2026 7:17 PM, Konstantin Shkolnyy wrote:
diff --git a/include/hw/s390x/s390-pci-bus.h b/include/hw/s390x/s390-pci-bus.h
index eb15cb8b2d..a71f562dfc 100644
--- a/include/hw/s390x/s390-pci-bus.h
+++ b/include/hw/s390x/s390-pci-bus.h
@@ -276,7 +276,6 @@ struct S390PCIIOMMU {
      S390PCIBusDevice *pbdev;
      AddressSpace as;
      MemoryRegion mr;
-    IOMMUMemoryRegion iommu_mr;
      MemoryRegion *dm_mr;
      bool enabled;
      uint64_t g_iota;
@@ -354,6 +353,7 @@ struct S390PCIBusDevice {
      S390MsixInfo msix;
      AdapterRoutes routes;
      S390PCIIOMMU *iommu;
+    IOMMUMemoryRegion iommu_mr;
      MemoryRegion msix_notify_mr;
      IndAddr *summary_ind;
      IndAddr *indicator;

Maybe I am missing something, but why do we need to remove iommu_mr from 
S390PCIIOMMU? S390PCIBusDevice already has a reference to the 
S390PCIIOMMU in its definition. So is there something about iommu_mr 
defined in S390PCIIOMMU makes it difficult to migrate? Its hard to 
understand from the commit message.

Thanks

Farhan