On 2026/06/23 12:01 PM, Shivang Upadhyay wrote: > Signed-off-by: Shivang Upadhyay <[email protected]> > --- > tests/functional/ppc64/test_powernv.py | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+)
The test addition looks fine, but the commit message body is missing. According to the official QEMU submission guidelines at: https://www.qemu.org/docs/master/devel/submitting-a-patch.html#write-a-meaningful-commit-message "Commit messages should be meaningful and should stand on their own as a historical record of why the changes you applied were necessary or useful." You may want to add a commit message body in the next version. Thanks, Amit > > diff --git a/tests/functional/ppc64/test_powernv.py > b/tests/functional/ppc64/test_powernv.py > index 0ea6c93e42..80801ee3dc 100755 > --- a/tests/functional/ppc64/test_powernv.py > +++ b/tests/functional/ppc64/test_powernv.py > @@ -27,6 +27,11 @@ class PowernvMachine(LinuxKernelTest): > 'buildroot/qemu_ppc64le_powernv8-2025.02/rootfs.ext2'), > 'aee2192b692077c4bde31cb56ce474424b358f17cec323d5c94af3970c9aada2') > > + # testdtb for power11, which contains string "hello world" in command > line > + ASSET_SAMPLE_DTB = Asset( > + > ('https://github.com/roz3x/qemu/raw/refs/heads/sample-dtb/output.dtb'), > + '2dd3330561768fc5c8e4b93aa29bc44c64278d186f1e0f8c584cdf15c3f8cf43') > + > def do_test_linux_boot(self, command_line = KERNEL_COMMON_COMMAND_LINE): > self.require_accelerator("tcg") > kernel_path = self.ASSET_KERNEL.fetch() > @@ -104,6 +109,20 @@ def do_test_ppc64_powernv(self, proc): > # Device detection output driven by udev probing is sometimes cut off > # from console output, suspect S14silence-console init script. > > + def test_ppc64_powernv_external_dtb(self): > + self.set_machine('powernv11') > + self.require_accelerator("tcg") > + > + kernel_path = self.ASSET_KERNEL.fetch() > + sample_dtb_path = self.ASSET_SAMPLE_DTB.fetch() > + self.vm.set_console() > + self.vm.add_args('-kernel', kernel_path, > + '-dtb', sample_dtb_path) > + self.vm.launch() > + > + # check if custom dtb is reflected or not > + wait_for_console_pattern(self, "Kernel command line: hello world", > self.panic_message) > + > def test_powernv8(self): > self.set_machine('powernv8') > self.do_test_ppc64_powernv('P8') > -- > 2.54.0 > >
