On Tue, 23 Jun 2026 at 18:01, Utkarsh Singh <[email protected]> wrote: > > On Tue, Jun 23, 2026 at 08:50:09AM -0600, Keith Busch wrote: > >On Tue, Jun 23, 2026 at 03:01:12PM +0100, Peter Maydell wrote: > >> Should we also have a "device-id" property here? Being able > >> to set the vendor-ID only seems unnecessarily limited, since > >> PCI IDs are a (vendor,device) tuple. > > > >Yes, the quirks are usually based off the same tuple, so there should be > >a way to set both when that's the justification for the patch. > Will add device-id and rename "vid" to "pci-vendor-id" in v2.
I don't have a strong opinion whether to have the pci- prefix or not, but please be consistent about whether you have it or not for vendor-id and device-id. -- PMM
