>From: Pierrick Bouvier <[email protected]> >Sent: Tuesday 16 June 2026 7:32 pm >To: Harry van Haaren | OPENCHIP <[email protected]>; >[email protected] <[email protected]> >Cc: [email protected] <[email protected]>; [email protected] ><[email protected]> >Subject: Re: [PATCH 1/2] plugins/execlog: fix segfault/race-cond on per-vCPU >structures > >Hi Harry, > >On 6/16/2026 9:12 AM, Harry van Haaren | OPENCHIP wrote: >> From: Harry van Haaren <[email protected]> >> >> The existing code in execlog was never upgraded to the Scoreboard >> API, resulting in a bespoke implementation of per-vCPU datastructure >> handling. This had some race-conditions, and causes segfaults with >> a simple multi-threaded program and two instances of execlog running. >> >> The patch here refactors the custom GArray and GRWLock code away, and >> uses the scoreboard APIs like the other plugins. This solves the >> "printing while expanding" race-condition of two plugins with multiple >> threads in the guest, and hence fixes a segfault. >> >> Signed-off-by: Harry van Haaren <[email protected]> >> >> --- >> >> Hi Qemu-Devel! >> >> This is my first contribution to QEMU itself, but I have worked on >> DPDK, OVS, and QEMU-RS a bit in the past. I have experience with >> mailing lists for patches and some QEMU internals. I've read the >> 'submitting a patch' guide, and ran checkpatch... so basics should >> be OK I hope! >> > >Welcome, and thanks for taking the time to contribute this!
Thank you! >It seems like there is no cover letter for your series, which is where >this paragraph should go ideally. Also, I think its presence is kind of >mandatory for tools manipulating it when having more than one patch, but >not 100% sure. > >I recommend you to use git-publish >(https://github.com/stefanha/git-publish) which does the right thing out >of the box and make sure your series looks like any other. Yet another >tool, sorry, but at least it's one of the "standard" here. Understood - have used cover letters before, but not using the git-publish tool, will use this for future patches/sets. >For the rest, I'll comment inline on the patches. Thanks for the quick response! I've not yet respun the patchset as I'm also getting the "footer" removed (I wasn't expecting it to be added). Will resend patchset (in-reply-to the 1st patch) with cover letter etc. once that is completed. Regards, -Harry <snip: rest of message content, including footer> The content, data, and any attached documents to this email are addressed exclusively to the addressee and are confidential and/or may be subject to a non-disclosure agreement. Any use, forwarding, disclosure, and/or copying, in whole or in part, without authorization is prohibited. If you have received this email in error, we apologize and, please notify the sender or Openchip immediately, and delete it from your system. El contenido, los datos y cualquier documento adjunto a este correo electrónico están dirigidos exclusivamente al destinatario y son confidenciales y/o pueden estar sujetas a un acuerdo de no revelación. Está prohibido cualquier uso, reenvío, divulgación o copia, total o parcial, sin autorización. Si has recibido este correo por error, te pedimos disculpas y agradecemos que lo notifiques de inmediato al remitente o a Openchip, y lo elimines de tu sistema. El contingut, les dades i qualsevol document adjunt a aquest correu electrònic estan dirigits exclusivament al destinatari i són confidencials i/o poden estar subjectes a un acord de no revelació. Està prohibit qualsevol ús, reenviament, divulgació o còpia, total o parcial, sense autorització. Si has rebut aquest correu per error, et demanem disculpes i agraïm que ho notifiquis d'immediat al remitent o a Openchip, i l'eliminis del teu sistema
