Il ven 17 apr 2026, 12:57 Magnus Kulke <[email protected]> ha
scritto:

> +#ifdef CONFIG_MSHV

+ VMSTATE_BUFFER(hv_lapic_state, APICCommonState),

+#endif


This breaks migration across releases for everyone else, and also across
builds that have different --enable-mshv. Compile-time defines are almost
always wrong in VMState definitions.

     DeviceState *vapic;
>      hwaddr vapic_paddr; /* note: persistence via kvmvapic */
>      uint32_t extended_log_dest;
> +
> +#ifdef CONFIG_MSHV
> +    uint8_t hv_lapic_state[sizeof(struct
> hv_local_interrupt_controller_state)];
> +#endif
>

No, this is called common for a reason. You need to implement a subclass
and handle migration in there.

Paolo

Reply via email to