The culprit appears to be patch 3:
migration: Run final save_query_pending at switchover
I can reproduce the issue consistently with:
while [ 1 ]; do
QTEST_QEMU_BINARY=./build/qemu-system-s390x \
./build/tests/qtest/migration-test \
--full -p /s390x/migration/colo/plain/secondary_failover_checkpoint ||
break
done
The patch you proposed seems to fix the issue.
Could you send it as a follow-up patch?
To make sure I get it straight, you suggest to merge your pull request
The merge request won't be merged as is. It's broken and I will
have to resend with a fix or without this series.
and then send a separate fix patch for that with a proper Fixes tag, right?
We either handle the breakage with an extra patch like you proposed,
which has to be sent and reviewed, or :
if Peter, Fabiano, Lukas
would prefer it to be integrated in the appropriate place, it
could be included in v5.
We can address this in a v5 respin of the series by fixing it
where it belongs: in patch 3. I think that's the right place,
since bisect breaks at that point.
Let's see what Peter and Fabiano think.
Thanks,
C.
