On Thu, Jul 2, 2026 at 2:39 PM Stefan Hajnoczi <[email protected]> wrote:
>
> On Wed, Jun 24, 2026 at 03:08:42PM +0800, Zhang Chen wrote:
> > Since previous patches introduced explicit monitor tracking and reference
> > counting via IOThreadHolder during initialization, standard global calls
> > to iothread_get_aio_context() are no longer appropriate for raw context
> > fetches.
> >
> > Switch the remaining fallback sites in monitor_suspend(), monitor_resume(),
> > and monitor_init_qmp() to use iothread_unsafe_get_aio_context(). This aligns
> > with the new safe ref/unref lifecycles introduced for monitor tracking.
>
> Why is the unsafe API used here? monitor_data_init() now takes a
> reference and gets the AioContext. Can you use that AioContext here
> instead of fetching it with iothread_unsafe_get_aio_context()?

Because we have some comments from this series V8 patches:
https://lists.gnu.org/archive/html/qemu-devel/2026-06/msg00375.html

If OK, I will back to the V8 code and follow the [PATCH V9 06/17] comments,
https://lists.gnu.org/archive/html/qemu-devel/2026-06/msg07323.html
based on Daniel's series for monitor parts in V10.

Thanks
Chen

Reply via email to