On Fri, Jul 03, 2026 at 07:50:43PM +0200, Paolo Bonzini wrote: > There are different "schools of thought" for that. Freezing introduces an > incorrect timing on the destination, not freezing introduces a jump. > > If you choose to freeze that's fine, QEMU does the same for KVM even though > KVM has alternative ioctls that allow not freezing. > > But currently it's the wrong > > place. I'll find some more fitting place to perform this ceremony. > > > > KVM uses a device for that, see kvnclock.c.
Makes sense, kvmclock looks like a good template. I'll use a similar object. > > Curiously the time-frozen source was obscuring another potentially more > > serious bug. The mshv vcpu dispatch loop currently does not honor a > > cpu->exit_request > > > Was that related to the other patch that was touching the vcpu thread loop? > yup, we need the same here, I'll address it as part of a migration-pt2 series. we only need to check for cpu->exit_request and break the loop if set. best, magnus
