On 7/7/2026 6:45 AM, Max Filippov wrote: > On Mon, Jul 6, 2026 at 3:43 PM Pierrick Bouvier > <[email protected]> wrote: >> >> Needed, else we get this error: >> dangerous relocation: l32r: misaligned literal target: .text > > This flag wasn't needed before because crt.S hasn't been built > with text-section-literals, why is it needed now? >
Previously, .S and .c were compiled in different steps, with different options. Now, with meson, we have to provide a single compiler command for all the files (no intermediate steps), which is a *hard* requirement to save user from dealing with compilation details in arch files. One consequence is that .c + .S combination gets -mtext-section-literals, which triggers this. Easily fixed by adding the .align section. I can add this in commit description, if you're ok with this explanation, and accept the patch. Regards, Pierrick >> Signed-off-by: Pierrick Bouvier <[email protected]> >> --- >> tests/tcg/xtensa/crt.S | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tests/tcg/xtensa/crt.S b/tests/tcg/xtensa/crt.S >> index 909872cd385..de8fd8c1cd7 100644 >> --- a/tests/tcg/xtensa/crt.S >> +++ b/tests/tcg/xtensa/crt.S >> @@ -6,6 +6,7 @@ >> jx a2 >> >> .text >> +.align 4 >> .global _start >> _start: >> #if XCHAL_HAVE_WINDOWED >> -- >> 2.47.3 >> >> > >
