On 7/6/2026 11:15 PM, Philippe Mathieu-Daudé wrote:
> Hi Pierrick,
> 
> On 7/7/26 00:32, Pierrick Bouvier wrote:
>> We allow target to declare a dockerfile containing required cc. We reuse
>> tests/docker/docker.py, and correctly set dependencies for tests on
>> original dockerfile.
>>
>> We specify list of hosts for which image can be built and contains
>> required cc, using cc_docker_arch.
>>
>> In case we rely on docker, we do not build tests by default anymore.
>>
>> Signed-off-by: Pierrick Bouvier <[email protected]>
>> ---
>>   tests/tcg/meson.build | 61 ++++++++++++++++++++++++++++++++++++++++---
>>   1 file changed, 57 insertions(+), 4 deletions(-)
>>
>> diff --git a/tests/tcg/meson.build b/tests/tcg/meson.build
>> index 0d2fefe8f51..57e7c3f8801 100644
>> --- a/tests/tcg/meson.build
>> +++ b/tests/tcg/meson.build
>> @@ -1,6 +1,7 @@
>>   cc_check_args = ['-xc', '/dev/null', '-o', '/dev/null', '-c']
>>   env = find_program('env')
>>   +docker_wrapper = find_program('../docker/docker.py')
>>   gdb_progs = ['gdb-multiarch', 'gdb']
>>   if config_host.has_key('GDB')
>>     gdb_progs = [config_host['GDB'], gdb_progs]
>> @@ -21,6 +22,8 @@ tcg_tests = {}
>>   # {
>>   #   'name_of_target': {
>>   #     'cc': 'cross_compiler',
>> +#     'cc_dockerfile': 'name_of_dockerfile',
>> +#     'cc_docker_arch': ['host_arch_supported (meson cpu)', ...],
> 
> This variable confuses me while reviewing the other patches in this
> series. What about naming explicitly as 'cc_docker_host_arch'?
>

Good for me if it helps!

Regards,
Pierrick

Reply via email to