On Wed, Jul 08, 2026 at 04:09:48PM +0200, Markus Armbruster wrote: > qmp_device_list_properties() skips properties whose name starts with > "legacy-". This is a flawed test for "is a legacy property". > > The test is flawed because non-legacy properties can and do start with > "legacy-". Back when it was added, no such properties existed. Right > now, three such properties do: property "legacy-cmb" of device "nvme", > and properties "legacy-cache" and "legacy-multi-node" of devices > "x86_64-cpu", "i386-cpu", and its children. > > This affects QMP command "device-list-properties", HMP command > "device_add T,help", and command line option "-device T,help". > > Legacy properties are gone since commit a61383f7ab (qdev: Legacy > properties are now unused internally, drop, 2025-10-22). This makes > the fix easy: delete the code that skips them. > > Reproducer: -device nvme,help doesn't show legacy-cmb before the > patch, and does after. > > Fixes: f4eb32b590 (qmp: show QOM properties in device-list-properties, > 2014-05-20) > Signed-off-by: Markus Armbruster <[email protected]> > --- > qom/qom-qmp-cmds.c | 7 ------- > 1 file changed, 7 deletions(-)
Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
