On Thu, Jul 09, 2026 at 07:42:27PM +0100, Jessica Clarke wrote: > FreeBSD 15 introduces a native inotify implementation rather than > requiring use of the kqueue-based libinotify package. This native > implementation does not generate the extra deleted events, so don't > expect them. However, the original implementation did have a bug that > caused IN_IGNORED to never be generated if you did not also watch for > IN_DELETE_SELF, which affects 15.0 and 15.1, but has been fixed and will > no longer apply in 15.2 / 16.0. > > Note that the deleted event check is for the userspace version, since > that governs whether libinotify is being used or not, whereas the > ignored event check is both for the userspace version (to check if we're > using the native syscall) and the kernel version (to check if the kernel > has the bug or not). > > All __FreeBSD_version values used here correspond to the value in-tree > at the time of the relevant commits. Since neither commit bumped the > value there will be a window of development snapshots between each > commit and the previous bump that will be incorrectly identified here, > but this is the best we can do, and something users of snapshots should > be prepared to deal with. > > Signed-off-by: Jessica Clarke <[email protected]> > --- > tests/unit/test-util-filemonitor.c | 29 ++++++++++++++++++++++++++++- > 1 file changed, 28 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <[email protected]> Tested-by: Daniel P. Berrangé <[email protected]> and queued. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
