Re: [PATCH] hw/misc/ivshmem: clear chardev handlers before freeing peers

Mon, 13 Jul 2026 00:09:30 -0700 

Cc'ing Gustavo

On 29/6/26 04:59, sundayjiang(è浩天) wrote:

 From 2a7fa17cd21d0a5c1ddf0f13f5c6b39375052aef Mon Sep 17 00:00:00 2001From: Haotian 
Jiang <[email protected]&gt;
Date: Mon, 29 Jun 2026 10:50:21 +0800
Subject: [PATCH] hw/misc/ivshmem: clear chardev handlers before freeing peers


ivshmem_exit() frees s-&gt;peers and s-&gt;msi_vectors but does not clear
the chardev handlers registered in ivshmem_common_realize(). &nbsp;Those
handlers are only removed later in object_finalize() via release_chr,
which runs after ivshmem_exit().


Between exit and finalize, ivshmem_read() can fire on pending chardev
data and process_msg_connect() dereferences the freed s-&gt;peers.
Additionally, s-&gt;peers, s-&gt;nb_peers, and s-&gt;msi_vectors are not
zeroed after free, leaving dangling pointers that make the UAF code
paths reachable.


Fix by clearing chardev handlers at the beginning of ivshmem_exit(),
before any resources they access are freed, and nullifying freed
pointers.


Fixes: f64a078d45a ("ivshmem: fix pci_ivshmem_exit()")
Link: https://gitlab.com/qemu-project/qemu/-/work_items/3594
Reported-by: Haotian Jiang <[email protected]&gt;
Cc: [email protected]
Signed-off-by: Haotian Jiang <[email protected]&gt;
---
&nbsp;hw/misc/ivshmem-pci.c | 6 ++++++
&nbsp;1 file changed, 6 insertions(+)


diff --git a/hw/misc/ivshmem-pci.c b/hw/misc/ivshmem-pci.c
index c987eebb98..ce0de5271e 100644
--- a/hw/misc/ivshmem-pci.c
+++ b/hw/misc/ivshmem-pci.c
@@ -938,6 +938,9 @@ static void ivshmem_exit(PCIDevice *dev)
&nbsp; &nbsp; &nbsp;IVShmemState *s = IVSHMEM_COMMON(dev);
&nbsp; &nbsp; &nbsp;int i;
&nbsp;
+ &nbsp; &nbsp;qemu_chr_fe_set_handlers(&amp;s-&gt;server_chr, NULL, NULL, 
NULL, NULL,
+ &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 
&nbsp; &nbsp; NULL, NULL, true);
+
&nbsp; &nbsp; &nbsp;migrate_del_blocker(&amp;s-&gt;migration_blocker);
&nbsp;
&nbsp; &nbsp; &nbsp;if (memory_region_is_mapped(s-&gt;ivshmem_bar2)) {
@@ -966,6 +969,8 @@ static void ivshmem_exit(PCIDevice *dev)
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;close_peer_eventfds(s, i);
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;}
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;g_free(s-&gt;peers);
+ &nbsp; &nbsp; &nbsp; &nbsp;s-&gt;peers = NULL;
+ &nbsp; &nbsp; &nbsp; &nbsp;s-&gt;nb_peers = 0;
&nbsp; &nbsp; &nbsp;}
&nbsp;
&nbsp; &nbsp; &nbsp;if (ivshmem_has_feature(s, IVSHMEM_MSI)) {
@@ -973,6 +978,7 @@ static void ivshmem_exit(PCIDevice *dev)
&nbsp; &nbsp; &nbsp;}
&nbsp;
&nbsp; &nbsp; &nbsp;g_free(s-&gt;msi_vectors);
+ &nbsp; &nbsp;s-&gt;msi_vectors = NULL;
&nbsp;}
&nbsp;
&nbsp;static int ivshmem_pre_load(void *opaque)


Reviewed-by: Philippe Mathieu-Daudé <[email protected]>

Reply via email to