On 26/06/17 04:50AM, Saif Abrar wrote:
> <...snip...>
>
> @@ -951,6 +1005,11 @@ static uint64_t pnv_phb4_reg_read(void *opaque, hwaddr
> off, unsigned size)
> case PHB_PCIE_LMR:
> /* These write-only bits always read as 0 */
> val &= ~(PHB_PCIE_LMR_CHANGELW | PHB_PCIE_LMR_RETRAINLINK);
> +
> + /* Check if link is active and set the bit */
> + if (is_link_active(phb)) {
> + val |= PHB_PCIE_LMR_LINKACTIVE;
> + }
> return val;
>
> /* Silent simple reads */
Looks good to me. Feel free to retain the rb.
Reviewed-by: Aditya Gupta <[email protected]>
Thanks,
- Aditya G
> --
> 2.52.0
>
