Reviewed-by: Glenn Miles <[email protected]>
Thanks,
Glenn
On Thu, 2026-07-09 at 17:23 +0200, Emmanuel Blot wrote:
> The pinN properties are accessed with visit_type_str() (values "low" and
> "high"), but were registered as type "bool", so introspection advertised
> a boolean while the accessors require a string. Register them as "str",
> matching the PCA9555 GPIO variant.
>
> Fixes: de0c7d543bca ("misc: Add a pca9554 GPIO device model")
> Signed-off-by: Emmanuel Blot <[email protected]>
> ---
> hw/gpio/pca9554.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/gpio/pca9554.c b/hw/gpio/pca9554.c
> index d4746719f9..904698cdce 100644
> --- a/hw/gpio/pca9554.c
> +++ b/hw/gpio/pca9554.c
> @@ -280,7 +280,7 @@ static void pca9554_initfn(Object *obj)
> char *name;
>
> name = g_strdup_printf("pin%d", pin);
> - object_property_add(obj, name, "bool", pca9554_get_pin,
> pca9554_set_pin,
> + object_property_add(obj, name, "str", pca9554_get_pin,
> pca9554_set_pin,
> NULL, NULL);
> g_free(name);
> }
>