On 2026/07/17 10:52, Bin Guo wrote:
The scanout_bitmask field is uint32_t, but all six bit operations used
the signed literal `1 << shift`. When the shift count reaches 31 this
is undefined behavior (signed integer overflow). Replace every
occurrence with the BIT() macro to perform an unsigned shift, which is
well-defined for all bit positions 0-31 and consistent with QEMU
bit-operation conventions.
No functional change; the result is already stored in a uint32_t, so
the generated code is identical on most platforms.
Reviewed-by: Marc-André Lureau <[email protected]>
Signed-off-by: Bin Guo <[email protected]>
Reviewed-by: Akihiko Odaki <[email protected]>
Regards,
Akihiko Odaki
