On 07/15/2012 01:54 PM, Stefan Weil wrote: > Am 15.07.2012 22:26, schrieb Mike Frysinger: >> We should not quote the PKG_CONFIG setting as this deviates from the >> canonical upstream behavior that gets integrated with all other build >> systems, and deviates from how we treat all other toolchain variables >> that we get from the environment. >> >> Ultimately, the point is that it breaks passing custom flags directly >> to pkg-config via the env var where this normally works elsewhere, >> and it used to work in the past. > > > What about passing custom flags with QEMU_PKG_CONFIG_FLAGS? > > Removing the quotes will not allow paths containing spaces, > so that's not a good idea.
Actually, it IS a good idea. The de facto standard build environment requires that pkg-config is not allowed to live in a path containing spaces, precisely so that you can override the variable to pass options to your preferred location of pkg-config; and if your build setup is truly so messed up as to have pkg-config installed in a canonical location with spaces, then you can also tweak your unusual environment to provide a symlink to pkg-config that does not contain spaces as the workaround. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
