On 7/16/2026 3:25 AM, Daniel P. Berrangé wrote: > The '--engine' arg accepts either 'podman' or 'docker', which is > not sufficiently granular to map directly to a command. This > means that docker.py still has to then probe the exact command > to use. > > Meanwhile the 'probe' command prints out the full command to use > but this cannot be passed back to docker.py to avoid probing > again, so the caching is only useful in the few case where we > run a container directly bypassing docker.py. > > Address this by replacing --engine with --command for docker.py. > > This in turn requires the --container-engine configure arg to be > replaced with --container-command. > > With these changes the container command is probed at most once > during configure and never again, while running in an unconfigured > tree will still probe on demand. > > Signed-off-by: Daniel P. Berrangé <[email protected]> > --- > > In v3: > > - Avoid bashism when testing probe result > > configure | 25 +++++++------ > tests/docker/Makefile.include | 13 ++++--- > tests/docker/docker.py | 67 ++++++++++++----------------------- > 3 files changed, 40 insertions(+), 65 deletions(-) >
This was merged into master (43bf3a0ce969782c4394fabc94777ba880b3598d). Thank you for your contribution! Regards, Pierrick
