Mitsuru Kariya <[email protected]> writes: > Thank you for reviewing, and I'm sorry for the late reply. > > Markus Armbruster <[email protected]> writes: >> Actually, it's "transmitted data may remain unacknowledged, or >> buffered data may remain untransmitted". Moreover, the interaction >> with @keep-alive is not mentioned. ... Have it point to tcp(7) for >> details? Perhaps something like [...] What do you think? > > Agreed, thanks -- adopted in v2. I took your wording almost verbatim, > with two small adjustments: > - reflowed to stay within the 70-column limit the QAPI doc checker > enforces (the original wrapping tripped it), and > - kept "(Since 11.1)" to match the neighbouring members. > The interaction with @keep-alive is left to the tcp(7) reference, as you > suggested, to keep it short. I also updated the -netdev stream > addr.user-timeout entry in qemu-options.hx to match (per your other > comment). I've added your Suggested-by to the patch. > > The text now reads: > > # @user-timeout: maximum time in milliseconds that transmitted data > # may remain unacknowledged, or buffered data may remain > # untransmitted, before the connection is closed. See tcp(7) > # for details. Only supported for TCP sockets on systems where > # the TCP_USER_TIMEOUT socket option is defined (Linux only). > # When set to 0, system setting is used. (Since 11.1)
Better. Swap "See tcp(7) for details." and the next sentence, to hopefully help the reader understand what to look for in tcp(7)?
