Philippe Mathieu-Daudé <[email protected]> writes:
> Hi,
>
> On 21/5/26 16:54, [email protected] wrote:
>> From: Marc-André Lureau <[email protected]>
>> gpa2hva() returns a referenced MemoryRegion via its p_mr out-parameter
>> (inherited from memory_region_find()), but both SEV callers were failing
>> to release it.
>
> Comment orthogonal to your fix; odd to have a non-monitor code
> call an undocumented monitor method.
Which one?
> Should the method be moved
> out of monitor/hmp-cmds.c somewhere into system/ and documented
> (likely in system/physmem.c, also moving the declaration to
> "system/memory.h")? Besides some day we should be able to build
> without monitor.
>
>> Fixes: c7f7e6970d3b ("sev: add sev-inject-launch-secret")
>> Signed-off-by: Marc-André Lureau <[email protected]>
