On Fri, 17 Jul 2026 18:32:39 -0700 Brian Cain <[email protected]>
wrote:
>
> diff --git a/hw/timer/qct-qtimer.c b/hw/timer/qct-qtimer.c
> new file mode 100644
> index 00000000000..fd56a7118b1
> --- /dev/null
> +++ b/hw/timer/qct-qtimer.c
> @@ -0,0 +1,613 @@
> [...]
> +
> +static const Property qct_qtimer_properties[] = {
> + DEFINE_PROP_UINT32("freq", QCTQtimerState, freq, QTIMER_DEFAULT_FREQ_HZ),
This property sets QCTQtimerState.freq, but it never reaches
QCTHextimerState.freq, right? So even though the user can set and read this
prop value, the value used in the actual calculations doesn't use this?
> + DEFINE_PROP_UINT32("freq-scale", QCTQtimerState, freq_scale, 1),
> + DEFINE_PROP_UINT32("nr_frames", QCTQtimerState, nr_frames, 2),
> + DEFINE_PROP_UINT32("nr_views", QCTQtimerState, nr_views, 1),
> + DEFINE_PROP_UINT32("frame_stride", QCTQtimerState, frame_stride, 0x1000),
> + DEFINE_PROP_UINT32("cnttid_0", QCTQtimerState, cnttid_0, 0x11),
> + DEFINE_PROP_UINT32("cnttid_1", QCTQtimerState, cnttid_1, 0x0),
> +};
> +
