On 7/21/26 19:19, Paolo Bonzini wrote:
When documenting the invariant that mode pages need to fit the smallest
output buffer of all callers (which is SCSI_MAX_MODE_LEN), the expression
used by the assertion was incorrect.
Even though SCSI_MAX_MODE_LEN is indeed 256, using "length < 256" had
two issues: 1) it used the wrong operator, since "length < ..." is more
related to having room for extra data; 2) it missed the extra two bytes
for page number and length.
Signed-off-by: Paolo Bonzini <[email protected]>
---
hw/scsi/scsi-disk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
It hitting this assert possible during normal operations?
I'm picking this up for qemu-stable.
Please let me know if I shoudn't.
Thanks,
/mjt
