Hi Shivang, Thanks for making the suggested changes and sending a v2. My comments are inline.
On 2026/07/25 11:16 PM, Shivang Upadhyay wrote: > While running remote interrupts test, without libslirp-devel installed, > facing the following panic logs. > > File > ... > raise VMLaunchFailure( > ...<3 lines>... > ) from exc > ... > Output: qemu-system-ppc64: -netdev user,id=net0: network backend > 'user' is not compiled into this binary > > Adding netdev user requirement for this test. > > Suggested-by: Amit Machhiwal <[email protected]> > Suggested-by: Thomas Huth <[email protected]> > Signed-off-by: Shivang Upadhyay <[email protected]> > --- > tests/functional/ppc64/test_powernv.py | 1 + > 1 file changed, 1 insertion(+) Tested on a system without libslirp-devel. Test is correctly skipped: ok 1 test_powernv.PowernvMachine.test_linux_remote_interrupts # SKIP no support for user networking 1..1 Tested-by: Amit Machhiwal <[email protected]> > > diff --git a/tests/functional/ppc64/test_powernv.py > b/tests/functional/ppc64/test_powernv.py > index bac2017e18..9a95b6011d 100755 > --- a/tests/functional/ppc64/test_powernv.py > +++ b/tests/functional/ppc64/test_powernv.py > @@ -91,6 +91,7 @@ def test_linux_smt_boot(self): > def test_linux_remote_interrupts(self): > self.require_accelerator("tcg") > self.set_machine('powernv') > + self.require_netdev('user') One minor nit: require_netdev('user') is placed after set_machine(). Though it's not necessary, I would prefer to group all require_* guards together at the top before any setup, so it's immediately clear what preconditions the test has. Either way: Reviewed-by: Amit Machhiwal <[email protected]> ~Amit > > # Have below setup in this test: > # 1. e1000e attached to pcie.6, which is from 7th PHB, belonging to > 2nd > -- > 2.54.0 > >
