On Mon, 27 Jul 2026 at 04:27, Gavin Shan <[email protected]> wrote: > > Similar to what's done in commit 4a73aee88140 ("softmmu: Use memmove in > flatview_write_continue"), there are more sites where the overlapping > source and destination buffer are allowed for the directly accessible > regions. Use memmove() in those sites, listed as below. > > hw/remote/vfio-user-obj.c::vfu_object_mr_rw > include/system/memory.h::address_space_read > system/physmem.c::flatview_read_continue_step > > Signed-off-by: Gavin Shan <[email protected]>
Reviewed-by: Peter Maydell <[email protected]> Even if the overlap isn't possible, it's definitely better to use memmove() than to have to think hard about whether there's some situation where it might happen :-) thanks -- PMM
