On 07/17/2012 08:53 PM, Stefan Hajnoczi wrote:
On Tue, Jul 3, 2012 at 10:20 AM, Harsh Prateek Bora
<ha...@linux.vnet.ibm.com> wrote:
Existing simpletrace backend allows to trace at max 6 args and does not
support strings. This newer tracelog format gets rid of fixed size records
and therefore allows to trace variable number of args including strings.
Sample trace:
v9fs_version 0.000 tag=0xffff id=0x64 msize=0x2000 version=9P2000.L
v9fs_version_return 6.705 tag=0xffff id=0x64 msize=0x2000 version=9P2000.L
v9fs_attach 174.467 tag=0x1 id=0x68 fid=0x0 afid=0xffffffffffffffff
uname=nobody aname=
v9fs_attach_return 4720.454 tag=0x1 id=0x68 type=0xffffffffffffff80
version=0x4f2a4dd0 path=0x220ea6
I have successfully tested it with the fix that I posted. Writing
simpletrace.Analyzer Python scripts still works - now with string
arguments too :).
Besides the last few comments on Patch 2, this looks okay now.
Thanks, I have the updated patches ready except for the question asked
on prev reply. Shall I fold your fix in patch 2 with comments as
necessary. Let me know if I need to add your s-o-b after merging your
fix in patch #2? You can update the commit message as you feel
appropriate while merging to your tree though.
regards,
Harsh
Stefan
