On Tue, Jul 28, 2026 at 03:38:53PM +0100, Peter Maydell wrote: > On Tue, 28 Jul 2026 at 15:34, Peter Xu <[email protected]> wrote: > > I think the bit ops should be more efficient. I plan to queue v5 with a > > fixup, v5 here: > > > > https://lore.kernel.org/qemu-devel/[email protected]/ > > > > Fixup: > > > > diff --git a/system/physmem.c b/system/physmem.c > > index fbe7df2391..2f37cbeb07 100644 > > --- a/system/physmem.c > > +++ b/system/physmem.c > > @@ -3162,13 +3162,18 @@ void qemu_ram_move(void *dst, const void *src, > > size_t n) > > { > > uintptr_t test, len; > > > > - if (src == dst || n == 0) { > > + if (n == 0) { > > return; > > } > > As we're dropping the src==dst check here, we also need to drop > the "and the memory areas do not overlap" clause from the > documentation comment. > > Otherwise I'm happy with the v5 with that fixup applied, > and you can apply my Reviewed-by: tag.
Will do, thanks. -- Peter Xu
