On 31/7/26 10:35, Philippe Mathieu-Daudé wrote:
Hi Stefan,
On 30/7/26 22:58, Stefan Hajnoczi wrote:
virtio_add_queue()'s queue_size argument is a signed int. The
vdev->vq[i].vring.num and num_default fields are already declared as
unsigned int, so change the virtio_add_queue() argument's type for
consistency.
A note on consistency: the VIRTIO specification defines queue size as an
unsigned 16-bit value.
Why not use uint16_t then?
(Otherwise size_t is more explicit for unsigned int size).
QEMU's device models variously use uint16_t,
uint32_t, and other unsigned types for queue size qdev properties.
virtio_add_queue() limits queue size to the much smaller
VIRTQUEUE_MAX_SIZE (1024) constant, so the different widths don't really
matter.
I have checked that all callers of virtio_add_queue() pass an unsigned
queue size.
Signed-off-by: Stefan Hajnoczi <[email protected]>
---
include/hw/virtio/virtio.h | 2 +-
hw/virtio/virtio.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
