Re: [PATCH RFC 13/15] hw/virtio/vhost-user: add shadow virtqueues and eventfd intercepts

[Connor Kite]

On Fri, Jul 24, 2026 at 6:45 AM Akihiko Odaki
<od...@rsg.ci.i.u-tokyo.ac.jp> wrote:
>
>
> This is not undone in case of errors.
>

I've added event_notifier_cleanup calls to the errors here.  As Hanna mentioned,
I have svq_cleanup added in a later patch but should probably pull it
forward.  I
believe that currently doesn't clean up notifiers, so I will be sure
to do that as well.

> > +
> > +        if (svq->hdev_kick.initialized == false) {
>
> Simpler: if (!svq->hdev_kick.initialized)
>
> Regards,
> Akihiko Odaki
>

This is now simplified.

Thanks!
Connor