From: Sam Heney <[email protected]>
The test_precopy_tcp_tls_no_hostname test and its start hook use
TestMigrateTLSX509 and migrate_hook_start_tls_x509_common(), which
are only defined when CONFIG_TASN1 is set. This means building with
gnutls enabled but libtasn1 unavailable fails:
../tests/qtest/migration/tls-tests.c: In function
'migrate_hook_start_tls_x509_no_host':
../tests/qtest/migration/tls-tests.c:510:5: error: unknown type name
'TestMigrateTLSX509'
Guard the test with CONFIG_TASN1 like the other x509 tests.
Fixes: df9c38b19af8 ("tests/qtest/migration: Add a NULL parameters test for
TLS")
Signed-off-by: Sam Heney <[email protected]>
Link:
https://lore.kernel.org/r/[email protected]
Signed-off-by: Peter Xu <[email protected]>
---
tests/qtest/migration/tls-tests.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/migration/tls-tests.c
b/tests/qtest/migration/tls-tests.c
index 827cc7bcf8..9bdb1165af 100644
--- a/tests/qtest/migration/tls-tests.c
+++ b/tests/qtest/migration/tls-tests.c
@@ -492,6 +492,7 @@ static void test_precopy_tcp_no_tls(char *name,
MigrateCommon *args)
test_precopy_common(args);
}
+#ifdef CONFIG_TASN1
static void *
migrate_hook_start_tls_x509_no_host(QTestState *from, QTestState *to)
{
@@ -519,7 +520,6 @@ static void test_precopy_tcp_tls_no_hostname(char *name,
MigrateCommon *args)
test_precopy_common(args);
}
-#ifdef CONFIG_TASN1
static void test_precopy_tcp_tls_x509_default_host(char *name,
MigrateCommon *args)
{
@@ -719,8 +719,10 @@ void migration_test_add_tls(MigrationTestEnv *env)
migration_test_add("/migration/precopy/tcp/no-tls",
test_precopy_tcp_no_tls);
+#ifdef CONFIG_TASN1
migration_test_add("/migration/precopy/tcp/tls/no-hostname",
test_precopy_tcp_tls_no_hostname);
+#endif /* CONFIG_TASN1 */
migration_test_add("/migration/precopy/unix/tls/psk",
test_precopy_unix_tls_psk);
--
2.54.0
