On 10.08.26 17:12, Daniel P. Berrangé wrote:
Most, but not all, of the shell I/O tests assign an email address to
the 'owner' shell variable. This variable is never used for anything
so gets reported as a dead assignment by shellcheck. The same is also
not done for the python I/O tests, though some include owner= in a
comment.
Mostly the 'owner=' variable seems to be an alternative to expressing
an "Author: NAME <EMAIL>" comment, but without the NAME. While they
could be converted to Author comments, this does not have a benefit
over using Git history and are not widely used in QEMU source code.
Git records activity over time so is more representative than the
initial author. Meanwhile the MAINTAINERS file, also expresses a
notion of ownership over the maint of files.
Signed-off-by: Daniel P. Berrangé<[email protected]>
Reviewed-by: Vladimir Sementsov-Ogievskiy <[email protected]>
--
Best regards,
Vladimir
