Reviewed-by: Glenn Miles <[email protected]> Thanks,
Glenn On Tue, 2026-08-18 at 12:33 +0530, Chinmay Rath wrote: > On 8/17/26 21:26, Miles Glenn wrote: > > Seems like you are fixing a bug here. Does this require a "Fixes" tag? > Hi Glenn, > > Thanks for reviewing the patches in the series ! > > I wouldn't consider this a bug since this particular patch does not fix > any wrong or missing behavior from a specific commit. The new > modifications to the ICBT instruction in the recent ISA versions were > simply not incorporated in the qemu code. So no previous commit is truly > at fault here. > > Tasmiya had observed certain HTX workload being run in TCG env caused > illegal instruction error, due to ICBT not supported as expected in the > latest ISA; which brought this to our attention. > > Regards, > Chinmay > > Thanks, > > > > Glenn > > > > On Wed, 2026-07-15 at 18:26 +0530, Chinmay Rath wrote: > > > The summary of changes in Power ISA version 2.07B mentions : > > > "ICBT instruction has been moved from the Embedded category > > > to the Base category". > > > Updating ICBT flag for the same. > > > > > > While we are at it, correct the invalid mask as per the ISA as well. > > > > > > Signed-off-by: Chinmay Rath <[email protected]> > > > --- > > > target/ppc/translate.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/target/ppc/translate.c b/target/ppc/translate.c > > > index 8dab54ccee..3cd849c706 100644 > > > --- a/target/ppc/translate.c > > > +++ b/target/ppc/translate.c > > > @@ -4559,8 +4559,8 @@ GEN_HANDLER2_E(tlbilx_booke206, "tlbilx", 0x1F, > > > 0x12, 0x00, 0x03800001, > > > GEN_HANDLER(wrtee, 0x1F, 0x03, 0x04, 0x000FFC01, PPC_WRTEE), > > > GEN_HANDLER(wrteei, 0x1F, 0x03, 0x05, 0x000E7C01, PPC_WRTEE), > > > GEN_HANDLER(dlmzb, 0x1F, 0x0E, 0x02, 0x00000000, PPC_440_SPEC), > > > -GEN_HANDLER2_E(icbt_440, "icbt", 0x1F, 0x16, 0x00, 0x03E00001, > > > - PPC_BOOKE, PPC2_BOOKE206), > > > +GEN_HANDLER2_E(icbt_440, "icbt", 0x1F, 0x16, 0x00, 0x02000001, > > > + PPC_BOOKE, (PPC2_BOOKE206 | PPC2_ISA207)), > > > GEN_HANDLER2(icbt_440, "icbt", 0x1F, 0x06, 0x08, 0x03E00001, > > > PPC_440_SPEC), > > > GEN_HANDLER(mfvscr, 0x04, 0x2, 0x18, 0x001ff800, PPC_ALTIVEC),
