On Tue, Jul 17, 2012 at 08:28:40PM +0100, Peter Maydell wrote: > On 17 July 2012 20:24, Stefan Weil <s...@weilnetz.de> wrote: > > The arguments why -Werror is a bad idea for some configure tests > > are reasonable. > > > > Nevertheless the QEMU community was able to produce thousands of > > lines of code which compile without a warning, so we should be able > > to create warning and error free code for a handful of configure > > tests. > > The trouble is that the warnings and errors here don't cause the > build to fail noisily; that's a big distinction IMHO. > I suppose we could make compile_prog do something like: > * run the compile test > * if it fails => test failure as now > * if it succeeds (and we're doing a Werror build at all), > rerun the same test with -Werror > * if that fails, abort configure with an error message > Then we would have the same "make the problem obvious" effect > that plain -Werror provides for our main compilation. > > > The 4 patches above are valid and can be applied with or without > > -Werror, therefore qemu-trivial or whoever does not have to wait for > > Peter's patch. > > Yes, I agree we might as well fix these errors since we've now > noticed them, regardless of whether or not we apply my patch > (which I've just sent).
Build/configure fixes should go straight into qemu.git. Stefan
