Hi Zoltan On Wed, Aug 19, 2026 at 3:18 PM BALATON Zoltan <[email protected]> wrote: > > On Wed, 19 Aug 2026, [email protected] wrote: > >> Most of thte display adapters are emulating old hardware which is not > >> relevant to virtualization use cases. > >> > >> The exceptions that should be considered secure are Cirrus (PCI, not > >> ISA), Bochs, QXL, RAMFB, VGA (PCI, MMIO, not ISA) and VMWare VGA. > >> > >> The Cirrus PCI decision is borderline. It has been heavily used with > >> virtualization in the past, but these days VGA / RAMFB are strongly > >> recommended instead. Due to its historical usage though, we can > >> consider the code fairly mature, even if no longer hugely relevant > >> to virtualization use cases. > >> > >> Signed-off-by: Daniel P. Berrangé <[email protected]> > >> Message-ID: <[email protected]> > >> > >> diff --git a/hw/display/artist.c b/hw/display/artist.c > >> index 3c884c92437c..caab4d1d4c52 100644 > >> --- a/hw/display/artist.c > >> +++ b/hw/display/artist.c > >> @@ -1504,6 +1504,7 @@ static const TypeInfo artist_info = { > >> .instance_size = sizeof(ARTISTState), > >> .instance_init = artist_initfn, > >> .class_init = artist_class_init, > >> + .secure = false, > >> }; > >> > >> static void artist_register_types(void) > >> diff --git a/hw/display/ati.c b/hw/display/ati.c > >> index f7c0006a879d..6e332e02d2fb 100644 > >> --- a/hw/display/ati.c > >> +++ b/hw/display/ati.c > >> @@ -1080,6 +1080,7 @@ static const TypeInfo ati_vga_info = { > >> .instance_size = sizeof(ATIVGAState), > >> .class_init = ati_vga_class_init, > >> .instance_init = ati_vga_init, > >> + .secure = false, > > I've missed the original series but why isn't the default false and > devices that are secured set it to true? That way a new device would not > be set secure unless the author explicitly sets it which seems better than > assuming devices are secure when most of them aren't. Or if false is > already the default why is it set everywhere? Isn't it enough to mark > secure devices?
Isn't it already the case, since fields are 0-initialized? I think Daniel just tried to go through it and make it explicit what is secure or not.
