On 8/20/26 09:45, Michael Tokarev wrote:
On 8/13/26 03:50, Richard Henderson wrote:
Hi Yogesh,
The main problem with your patch is where you've placed the change:
tcg_region_initial_alloc__locked is also used by tcg_region_reset_all,
used by tb_flush. Along that path, we really can't have a failure.
The path on which we can defer allocation is via tcg_register_thread.
The second change I made is to use code_buf_ptr == NULL to signal
reallocation is required. In addition, tcg_tb_alloc doesn't need
to immediately fail: in the interim since thread creation, we may
well have performed a tb_flush already.
Please have a try vs your hotplug test case.
Hi!
Is this a qemu-stable material?
I'm not picking it up, but it feels I should :)
Yes, I think it could be trivially picked up. I don't think any of this code has changed
in years.
r~
