Hi Marc-André, thanks for looking at it.
Marc-André Lureau <[email protected]> wrote: > maybe add ? > case AUX_RESEND: > /* Resending the last packet is not implemented. */ > break; I'd rather not -- a silent case is exactly what this patch removes, and 0xFE is the worst byte to leave silent: a guest only sends it once it has decided the previous reply was bad, so it is already in its error path when it ends up waiting out the timeout. The keyboard path settled the same question in 06b3611fc2a3 ("ps2: reject unknown commands, instead of blindly accepting them"); the mouse path was simply not touched. And answering 0xFE properly means remembering the last byte sent and migrating it, which is why the 0xFC stage is left out too. If you are happy with the patch, would you mind adding your Reviewed-by and taking it through your tree? hw/input/ps2.c has no F: entry in MAINTAINERS, but the recent ps2.c changes went in through you, so you seemed the right person to ask. Thanks, Christian
