On Mon, 24 Aug 2026 at 14:14, Frager, Neal <[email protected]> wrote: > > AMD General > > Hi Stewart, > > > The -I$(XEN_ROOT)/tools/include added to QEMU's extra-cflags causes > > __XEN_INTERFACE_VERSION__ to be defined before xen_native.h is included, > > triggering an include-order assertion. Downgrade to a warning since the > > version is consistent in cross-compile. > > Ref: https://github.com/qemu/qemu/commit/e2abfe5ec6
> > This is a buildroot issue, so I don't believe it's necessary to fix from the > > qemu side. > > I am not sure I fully agree here. While this is a buildroot identified issue, > there could be other use cases for __XEN_INTERFACE_VERSION__ to be defined > before xen_native.h is included. But what, though? > And what we have found is that if > __XEN_INTERFACE_VERSION__ to be defined before xen_native.h is included, it > is not a hard error. For buildroot, the qemu works just fine in spite of > this. I think that just means you got lucky. Either there is a hard requirement for one header to be included before the other (in which case it must be a #error, and whatever is causing the mis-ordering to happen must be fixed), or it's fine for the ordering to be either way (in which case it doesn't even need to be a #warning). thanks -- PMM
