On 8/12/26 11:21 AM, Joshua Daley wrote:
> Split test_s390x_secure_ipl() into two subtests. Each tests with a
> different boot device: virtio-blk-ccw or virtio-blk-pci. Use a state var
> such that the setup is run only once.
[...]
> +
> + @skipBigDataTest()
> + def test_s390x_secure_ipl_ccw(self):
> + """Test secure IPL with a virtio-blk-ccw boot device."""
> + self.require_accelerator('kvm')
> + if not self.setup_done:
> + self.setup_s390x_secure_ipl()
AFAICT this setup_done check won't do anything.
If I run this file I will enter setup twice, once for
test_secure_ipl.S390xSecureIpl.test_s390x_secure_ipl_ccw
and again for
test_secure_ipl.S390xSecureIpl.test_s390x_secure_ipl_pci
I think it's because each test will run with it's own instance of the class.
> + self.verify_s390x_secure_ipl('ccw')
> +
> + @skipBigDataTest()
> + def test_s390x_secure_ipl_pci(self):
> + """Test secure IPL with a virtio-blk-pci boot device."""
> + self.require_accelerator('kvm')
> + if not self.setup_done:
> + self.setup_s390x_secure_ipl()
Same
Unless this is really time consuming, I think the simple answer is to
just let the setup run twice and don't try to share between the 2 instances?
Thanks,
Matt
