On 18/08/2026 12:11, Marc-André Lureau wrote:
The getter and setter use visit_type_size, not visit_type_int.Fixes: 8ec1e4f1ef97 ("ppc/pnv: add phb-id/chip-id PnvPHB3RootBus properties") Fixes: b7c1750dc440 ("ppc/pnv: add phb-id/chip-id PnvPHB4RootBus properties") Signed-off-by: Marc-André Lureau <[email protected]> --- hw/pci-host/pnv_phb3.c | 4 ++-- hw/pci-host/pnv_phb4.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/pci-host/pnv_phb3.c b/hw/pci-host/pnv_phb3.c index 4ffdb4ce31ae..0471b009ec2f 100644 --- a/hw/pci-host/pnv_phb3.c +++ b/hw/pci-host/pnv_phb3.c @@ -1164,12 +1164,12 @@ static void pnv_phb3_root_bus_class_init(ObjectClass *klass, const void *data) { BusClass *k = BUS_CLASS(klass);- object_class_property_add(klass, "phb-id", "int",+ object_class_property_add(klass, "phb-id", "size", pnv_phb3_root_bus_get_prop, pnv_phb3_root_bus_set_prop, NULL, NULL);- object_class_property_add(klass, "chip-id", "int",+ object_class_property_add(klass, "chip-id", "size", pnv_phb3_root_bus_get_prop, pnv_phb3_root_bus_set_prop, NULL, NULL); diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c index 705a5bcf074f..510edebc40de 100644 --- a/hw/pci-host/pnv_phb4.c +++ b/hw/pci-host/pnv_phb4.c @@ -1761,12 +1761,12 @@ static void pnv_phb4_root_bus_class_init(ObjectClass *klass, const void *data) { BusClass *k = BUS_CLASS(klass);- object_class_property_add(klass, "phb-id", "int",+ object_class_property_add(klass, "phb-id", "size", pnv_phb4_root_bus_get_prop, pnv_phb4_root_bus_set_prop, NULL, NULL);- object_class_property_add(klass, "chip-id", "int",+ object_class_property_add(klass, "chip-id", "size", pnv_phb4_root_bus_get_prop, pnv_phb4_root_bus_set_prop, NULL, NULL);
Similar comment before that in pnv_phb3_root_bus_get_prop() and pnv_phb3_root_bus_set_prop() value is assigned to a uint64_t, but anyhow:
Reviewed-by: Mark Cave-Ayland <[email protected]> ATB, Mark.
