For ZBC/ZAC devices the write granularity is the physical block size, so
a 512e SMR disk exposed through a host_device backend has a logical block
size of 512 and a zone write granularity of 4096. We told the guest driver 512
while raw_co_zone_append() rejects anything that is not 4096 byte
aligned, so the driver saw a plain I/O error for a request it had been
told was valid.
Report the larger of the backend granularity and the logical block size
instead. The guest driver cannot issue writes finer than the logical
size, so the larger of the two is the constraint that applies. This
matches what a Linux guest derives for itself: blk_validate_zoned_limits()
raises zone_write_granularity to the logical block size, and
blk_stack_limits() stacks it with max().
Add it as a helper next to blkconf_blocksizes(), since it is derived from
a BlockConf and the limits of the backend below it, and use it for the
zone append offset check in check_zoned_request(), which validated
against bs->bl.write_granularity. The value reported to the driver and
the value that requests are validated against then cannot drift apart.
The helper cannot return zero because blkconf_blocksizes() always leaves
a logical block size behind, so the check no longer needs to guard
against an unset granularity.
Fixes: 4f7366506a96 ("virtio-blk: add zoned storage emulation for zoned
devices")
Signed-off-by: Niklas Cassel <[email protected]>
---
hw/block/block.c | 7 +++++++
hw/block/virtio-blk.c | 13 +++++++------
include/hw/block/block.h | 8 ++++++++
3 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/hw/block/block.c b/hw/block/block.c
index f187fa025d..1c3135843d 100644
--- a/hw/block/block.c
+++ b/hw/block/block.c
@@ -201,6 +201,13 @@ bool blkconf_blocksizes(BlockConf *conf, Error **errp)
return true;
}
+uint32_t blkconf_zone_write_granularity(BlockConf *conf)
+{
+ BlockDriverState *bs = blk_bs(conf->blk);
+
+ return MAX(bs->bl.write_granularity, conf->logical_block_size);
+}
+
bool blkconf_apply_backend_options(BlockConf *conf, bool readonly,
bool resizable, Error **errp)
{
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index f74cc3dbd0..f8cda1baa7 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -520,11 +520,11 @@ static bool check_zoned_request(VirtIOBlock *s, int64_t
offset, int64_t len,
}
if (append) {
- if (bs->bl.write_granularity) {
- if ((offset % bs->bl.write_granularity) != 0) {
- *status = VIRTIO_BLK_S_ZONE_UNALIGNED_WP;
- return false;
- }
+ uint32_t wg_mask = blkconf_zone_write_granularity(&s->conf.conf) - 1;
+
+ if (offset & wg_mask) {
+ *status = VIRTIO_BLK_S_ZONE_UNALIGNED_WP;
+ return false;
}
index = offset / bs->bl.zone_size;
@@ -1274,7 +1274,8 @@ static void virtio_blk_update_config(VirtIODevice *vdev,
uint8_t *config)
bs->bl.max_active_zones);
virtio_stl_p(vdev, &blkcfg.zoned.max_open_zones,
bs->bl.max_open_zones);
- virtio_stl_p(vdev, &blkcfg.zoned.write_granularity, blk_size);
+ virtio_stl_p(vdev, &blkcfg.zoned.write_granularity,
+ blkconf_zone_write_granularity(conf));
virtio_stl_p(vdev, &blkcfg.zoned.max_append_sectors,
bs->bl.max_append_sectors);
} else {
diff --git a/include/hw/block/block.h b/include/hw/block/block.h
index df941df19f..f98525c01a 100644
--- a/include/hw/block/block.h
+++ b/include/hw/block/block.h
@@ -114,6 +114,14 @@ bool blkconf_geometry(BlockConf *conf, int *trans,
unsigned cyls_max, unsigned heads_max, unsigned secs_max,
Error **errp);
bool blkconf_blocksizes(BlockConf *conf, Error **errp);
+/*
+ * The alignment constraint that applies to writes to a sequential zone. The
+ * medium may require a coarser granularity than the logical block size, while
+ * a guest cannot issue writes finer than the logical block size, so the
+ * constraint that applies is the larger of the two. A frontend must report
this
+ * value to its guest and validate requests against it.
+ */
+uint32_t blkconf_zone_write_granularity(BlockConf *conf);
bool blkconf_apply_backend_options(BlockConf *conf, bool readonly,
bool resizable, Error **errp);
--
2.55.0
